-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Scene not updated when changing an effect's input #69
Comments
It looks like a bug indeed, thanks for reporting |
Hmm I've tracked the input change down to https://github.com/QuantStack/GanyJS/blob/ebfdea022ddf068b56d6d18b0707091d4d885809/src/NodeMesh.ts#L166 in GanyJS and everything seems to be updated properly. I don't know much three.js so I'm afraid I can't do more to tackle the issue here. In the meantime I've found a workaround for my use case. |
Thanks for tracking it down. I fear this is due to the ThreeJS update. I'll try to find time to fix this. |
Hi, I recently encountered this issue myself and was just curious about the workaround you (@benbovy) implemented? For now I opted for clearing my output and re-creating it:
Hopefully your workaround is slightly more elegant than mine :) |
@Krande my workaround is the same than yours 🙂 |
😕 I need to find time to work on this |
No rush @martinRenou! That workaround is not ideal but it's only minor annoyance. |
(adapted from the notebook example in this repo):
I'd like to change the isocolor input, e.g., from another notebook cell
But it has no effect on the scene that is already rendered in cell 3 output. To see the new input color I need to re-execute that cell.
Is it the normal behavior? I see that
Effect.input
is synchronized so I'd rather expect that changing it would update the scene(s) already shown in output cells.The text was updated successfully, but these errors were encountered: