-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Performance while selecting nodes on a "big" tree #25
Comments
I have similar issue. I feel like every time I run it, memory footprint rises a lot and it slows down a bit. I don't know intended scope for the tree, maybe I'm expecting too much or I'm just doing it wrong, but here is example code (for JupyterLab). It's really dumb because it's based on code I'm using, but hopefully that's irrelevant.
And then next cell to create it:
Ignoring the time it takes to process first cell: In my use case, I wanted to browse and dynamically edit the tree, so it gets generated quite often. Is there a command I should be using to 'delete' the tree in between runs or something maybe? eventually it gets to the point where I get prompted to kill the tab and it taking ~40 secs |
You are right, this library's widget model's js code needs to be restructured. It currently stores all the created nodes in a global noderegistry (doesn't seem to delete nodes). and every click iterates through all the nodes (even from different trees) and deselects them. It could be made significantly faster with minor changes, but seems like the repo is now unmaintained. |
I have same issue. I add 800 or more 1000 nodes, error happens. |
#72 |
It takes a noticeable period (avg. 3 seconds) to highlight the node to be selected on a relatively big tree, say a thousand leaf nodes with the tree depth of 2. Any idea about improving the performance on big trees?
The text was updated successfully, but these errors were encountered: