Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Investigate headed differences in the UI tests for Firefox #6876

Open
jtpio opened this issue May 16, 2023 · 0 comments
Open

Investigate headed differences in the UI tests for Firefox #6876

jtpio opened this issue May 16, 2023 · 0 comments
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented May 16, 2023

In #6872 we noticed some differences for the rendering of the "Click to add a cell" button in Firefox when running the Playwright tests.

default (on CI)

The "Click to add a cell" button is displayed even when not actively hovering on it.

image

--headed

The "Click to add a cell" button is not displayed, which is the expected behavior.

image

We should consider investigating this more or report an issue on https://github.com/microsoft/playwright. Or check again later if the workaround can be removed in a future Playwright version:

/**
* Special case for firefox headless issue
* See https://github.com/jupyter/notebook/pull/6872#issuecomment-1549594166 for more details
*/
export async function hideAddCellButton(
page: IJupyterLabPageFixture
): Promise<void> {
await page
.locator('.jp-Notebook-footer')
.evaluate((element) => (element.style.display = 'none'));
}

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label May 16, 2023
@jtpio jtpio added maintenance and removed status:Needs Triage Applied to issues that need triage labels May 16, 2023
@jtpio jtpio added this to the 7.0.x milestone May 16, 2023
@jtpio jtpio modified the milestones: 7.0.x, 7.1.x Feb 2, 2024
@jtpio jtpio modified the milestones: 7.1.x, 7.2.x May 1, 2024
@jtpio jtpio modified the milestones: 7.2.x, 7.4.0 Oct 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant