Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Responsive Proxy for other Stream Types #502

Open
jwindgassen opened this issue Sep 16, 2024 · 1 comment
Open

Responsive Proxy for other Stream Types #502

jwindgassen opened this issue Sep 16, 2024 · 1 comment

Comments

@jwindgassen
Copy link

With #479, there is now support for proxying a text/event-stream, but not any other stream type (video/data). From what I can tell, this was originally not possible because of the way RewritableResponse works.

But with the new Stream Support, I don't see RewritableResponse used anywhere in the new implementation. Furthermore, the reference implementation ideonate/jhsingle-native-proxy/jhsingle_native_proxy/proxyhandlers.py#L249 has no restriction to the stream type and just exposes this as a configurable flag.

So is there still any reason we currently only support text/event-stream, or could this be expanded?

@jwindgassen
Copy link
Author

Hey @yuvipanda and @ganisback

As you were responsible for integrating this feature, I was hoping you might be able to give some more details about this issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant