Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

GET /server-proxy/server-infos net::ERR_TOO_MANY_REDIRECTS with notebook 6.5.7 and JupyterHub >= 4 #511

Open
cmd-ntrf opened this issue Nov 11, 2024 · 3 comments
Labels

Comments

@cmd-ntrf
Copy link
Contributor

cmd-ntrf commented Nov 11, 2024

Bug description

When running notebook 6.5.7, nbclassic 1.1.0 and JupyterHub >=4, ServersInfoHandler cannot be reached by the Javascript client code.

How to reproduce

  1. Create a virtual environment
  2. Install the following dependencies: jupyterhub 'notebook<7' jupyterlab jupyter-server-proxy
  3. Authenticate on the hub
  4. Look at the browser console

Expected behaviour

The javascript client code should be able to reach the server-proxy handler to get a list of available servers.

Actual behaviour

The javascript client code cannot reach the server-proxy handler, because it is missing the XSRF header.

More info

Adding the following function to ServersInfoHandler fixed the issue, but I am not sure it is what we want in the long run:

    def check_xsrf_cookie(self):
        pass
@cmd-ntrf cmd-ntrf added the bug label Nov 11, 2024
@manics
Copy link
Member

manics commented Nov 11, 2024

nbclassic is a different package to notebook<7. Which one are you using?

@cmd-ntrf
Copy link
Contributor Author

cmd-ntrf commented Nov 11, 2024

pip install 'notebook<7' currently installs notebook 6.5.7, which depends on nbclassic. Therefore, to your question, I guess both?

From PyPI:

Maintenance and security-related issues only are now being addressed in the 6.5.x branch. It depends on nbclassic for the HTML/JavaScript/CSS assets.

@cmd-ntrf cmd-ntrf changed the title GET /server-proxy/server-infos net::ERR_TOO_MANY_REDIRECTS with nbclassic and JupyterHub >= 4 GET /server-proxy/server-infos net::ERR_TOO_MANY_REDIRECTS with notebook 6.5.7 and JupyterHub >= 4 Nov 12, 2024
@cmd-ntrf
Copy link
Contributor Author

cmd-ntrf commented Nov 12, 2024

@manics : I have edited the title and issue to clarify what I am using.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants