-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Should we configure more defaults for opengraph? #4
Comments
my hope is actually that we can get this merged and just use auto-generated images: WDYT? |
Aha, so with that, the fields |
It was released last month https://github.com/wpilibsuite/sphinxext-opengraph/releases jupyterhub-sphinx-theme/pyproject.toml Line 20 in d4071da
Should it be up to the consuming repo to decide whether to set version constraints on the Sphinx plugins, or should that be handled by this theme? |
I figure if this theme depends on logic introduced in a dependency of a certain version, we should put a lower version requirement ( |
This is the typical boilerplate opengraph config for jupyterhub projects when I activate opengraph now. Should we perhaps provide a default value for ogp_image and ogp_use_first_image?
The text was updated successfully, but these errors were encountered: