Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make username_claim callable in CILogon #718

Closed
wants to merge 2 commits into from
Closed

Make username_claim callable in CILogon #718

wants to merge 2 commits into from

Conversation

yuvipanda
Copy link
Collaborator

Companion to #717

Fixes #712

@yuvipanda yuvipanda mentioned this pull request Jan 18, 2024
Merged
@yuvipanda yuvipanda marked this pull request as draft January 18, 2024 22:20
@yuvipanda
Copy link
Collaborator Author

Two issues here:

  1. jsonschema by default doesn't allow us to really do anything about callables or python objects, so we'll need to find a way to fix that
  2. Not sure why the CILogon tests are failing. I need to understand that better, and fix those.

@yuvipanda
Copy link
Collaborator Author

I'm not going to be working on this actively right now so going to close this

@yuvipanda yuvipanda closed this Jun 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CILogon] Can not use orcid as username_claim directly, an option is needed
1 participant
@yuvipanda