Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

/learn with wildcards not working in python 3.10 #1026

Closed
vaibhav-dhawan opened this issue Oct 11, 2024 · 2 comments
Closed

/learn with wildcards not working in python 3.10 #1026

vaibhav-dhawan opened this issue Oct 11, 2024 · 2 comments
Labels
bug Bugs reported by users

Comments

@vaibhav-dhawan
Copy link

Description

https://github.com/jupyterlab/jupyter-ai/pull/989/files

We are running into an issue with this change, as per: https://docs.python.org/3/library/glob.html#glob.iglob the include_hidden parameter was added in python 3.11, we are unable to run /learn with any wildcards on python 3.10

Reproduce

/learn *.py

Expected behavior

Runs through all files in directory

Context

Python 3.10, jup-ai 2.25.0

Error:
iglob() got an unexpected keyword argument 'include_hidden'

@vaibhav-dhawan vaibhav-dhawan added the bug Bugs reported by users label Oct 11, 2024
@krassowski
Copy link
Member

We need to run python tests with 3.9 and 3.13 if we don't do that yet. Otherwise a test for that function would come in handy too.

@dlqqq
Copy link
Member

dlqqq commented Oct 15, 2024

@vaibhav-dhawan Thank you for reporting this issue! This issue was fixed by #1029, which will be available in the next release.

@dlqqq dlqqq closed this as completed Oct 15, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Bugs reported by users
Projects
None yet
Development

No branches or pull requests

3 participants