Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add JupyterLab Dark theme galata snapshots to (at least) Documentation/debugger, documentation/general, jupyterlab/collapsible-headings, jupyterlab/debugger, jupyterlab/texteditor #14331

Open
andrii-i opened this issue Apr 5, 2023 · 1 comment
Labels
bug tag:Accessibility tag:CSS For general CSS related issues and pecadilloes tag:Testing

Comments

@andrii-i
Copy link
Contributor

andrii-i commented Apr 5, 2023

Description

Documentation/debugger, documentation/general, jupyterlab/collapsible-headings, jupyterlab/debugger, jupyterlab/texteditor don't have JupyterLab Dark galata snapshot tests to make sure there are no regressions in regards to changes from #14269 that ensures sufficient text contrast level of code line numbers.

It could be useful to add a snapshot test using dark mode to avoid regressions (could be a follow-up PR).

Originally posted by @krassowski in #14269 (review)

Reproduce

Note absence of JupyterLab Dark galata snapshots

@hxrshxz
Copy link
Contributor

hxrshxz commented Jan 26, 2025

am i supposed to make separate files for the tests or add tests to the existing files?
for eg -
@JasonWeill

src/
|-- components/
|   |-- Debugger/
|   |   |-- Debugger.tsx          # Main component
|   |   |-- DebuggerDark.tsx      # Dark mode variant
|   |   |-- Debugger.test.ts      # Tests for Debugger.tsx
|   |   |-- DebuggerDark.test.ts  # Tests for DebuggerDark.tsx

or Add changes to the existing ?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug tag:Accessibility tag:CSS For general CSS related issues and pecadilloes tag:Testing
Projects
None yet
Development

No branches or pull requests

3 participants