From 2f1339e8240fe5d68ed3fc6f193f8d74eb747715 Mon Sep 17 00:00:00 2001 From: sai-harsha-vardhan Date: Thu, 5 Sep 2024 12:55:35 +0530 Subject: [PATCH 1/4] ci: run check_v2 on merge queue --- .github/workflows/CI-push.yml | 37 +++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/.github/workflows/CI-push.yml b/.github/workflows/CI-push.yml index ace8d7eaf0a..5c1126ac71d 100644 --- a/.github/workflows/CI-push.yml +++ b/.github/workflows/CI-push.yml @@ -197,3 +197,40 @@ jobs: - name: Spell check uses: crate-ci/typos@master + + check-v2: + name: Check compilation for V2 features + runs-on: ubuntu-latest + + steps: + - name: Checkout repository + uses: actions/checkout@v4 + + - name: Install mold linker + uses: rui314/setup-mold@v1 + if: ${{ runner.os == 'Linux' }} + with: + make-default: true + + - name: Install Rust + uses: dtolnay/rust-toolchain@master + with: + toolchain: stable 2 weeks ago + components: clippy + + - name: Install rust cache + uses: Swatinem/rust-cache@v2.7.0 + + - name: Install just + uses: taiki-e/install-action@v2.41.10 + with: + tool: just + checksum: true + + - name: Run cargo check with v2 features enabled + shell: bash + # env: + # # Not denying warnings for now. + # # We only want to ensure successful compilation for now. + # RUSTFLAGS: "-D warnings -A clippy::todo" + run: just check_v2 From d90ac4f28ff189470c3c6ca85a7a612ceb645e4c Mon Sep 17 00:00:00 2001 From: sai-harsha-vardhan Date: Thu, 5 Sep 2024 15:35:59 +0530 Subject: [PATCH 2/4] run cargo check with features release and v2 --- .github/workflows/CI-pr.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/CI-pr.yml b/.github/workflows/CI-pr.yml index 722e0d22b16..d96edd978a7 100644 --- a/.github/workflows/CI-pr.yml +++ b/.github/workflows/CI-pr.yml @@ -316,3 +316,7 @@ jobs: # # We only want to ensure successful compilation for now. # RUSTFLAGS: "-D warnings -A clippy::todo" run: just check_v2 + + - name: Run cargo check enabling only the release and v2 features + shell: bash + run: cargo check --no-default-features --features "release,v2" From ef7f7e0ffc2e33aedc908d4ed687dcd1f06df0ae Mon Sep 17 00:00:00 2001 From: sai-harsha-vardhan Date: Thu, 5 Sep 2024 18:51:15 +0530 Subject: [PATCH 3/4] add release feature check in merge_group instead of just check_v2 --- .github/workflows/CI-pr.yml | 1 - .github/workflows/CI-push.yml | 14 ++------------ 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/.github/workflows/CI-pr.yml b/.github/workflows/CI-pr.yml index d96edd978a7..544aff79d17 100644 --- a/.github/workflows/CI-pr.yml +++ b/.github/workflows/CI-pr.yml @@ -302,7 +302,6 @@ jobs: - name: Install rust cache uses: Swatinem/rust-cache@v2.7.0 - - name: Install just uses: taiki-e/install-action@v2.41.10 with: diff --git a/.github/workflows/CI-push.yml b/.github/workflows/CI-push.yml index 5c1126ac71d..d48680c96ce 100644 --- a/.github/workflows/CI-push.yml +++ b/.github/workflows/CI-push.yml @@ -221,16 +221,6 @@ jobs: - name: Install rust cache uses: Swatinem/rust-cache@v2.7.0 - - name: Install just - uses: taiki-e/install-action@v2.41.10 - with: - tool: just - checksum: true - - - name: Run cargo check with v2 features enabled + - name: Run cargo check enabling only the release and v2 features shell: bash - # env: - # # Not denying warnings for now. - # # We only want to ensure successful compilation for now. - # RUSTFLAGS: "-D warnings -A clippy::todo" - run: just check_v2 + run: cargo check --no-default-features --features "release,v2" From 0ed558f70bc3b4a63b92ee0214fa62c51b68f271 Mon Sep 17 00:00:00 2001 From: sai-harsha-vardhan Date: Thu, 5 Sep 2024 18:57:57 +0530 Subject: [PATCH 4/4] remove clippy component while installing rust in check-v2 job --- .github/workflows/CI-pr.yml | 1 - .github/workflows/CI-push.yml | 1 - 2 files changed, 2 deletions(-) diff --git a/.github/workflows/CI-pr.yml b/.github/workflows/CI-pr.yml index 544aff79d17..a31d0450010 100644 --- a/.github/workflows/CI-pr.yml +++ b/.github/workflows/CI-pr.yml @@ -297,7 +297,6 @@ jobs: uses: dtolnay/rust-toolchain@master with: toolchain: stable 2 weeks ago - components: clippy - name: Install rust cache uses: Swatinem/rust-cache@v2.7.0 diff --git a/.github/workflows/CI-push.yml b/.github/workflows/CI-push.yml index d48680c96ce..0f92fc36c31 100644 --- a/.github/workflows/CI-push.yml +++ b/.github/workflows/CI-push.yml @@ -216,7 +216,6 @@ jobs: uses: dtolnay/rust-toolchain@master with: toolchain: stable 2 weeks ago - components: clippy - name: Install rust cache uses: Swatinem/rust-cache@v2.7.0