fix: toggle default value #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datron
approved these changes
Jan 31, 2025
ayushjain17
requested changes
Jan 31, 2025
| } | ||
| None => view! { <Toggle value=false on_change class name/> }.into_view(), | ||
| None => { | ||
| on_change.call(Value::Bool(false)); |
There was a problem hiding this comment.
this would get triggered on every re-render
this should be dealt at the moment when the type is being chosen by the user
ShubhranshuSanjeev
requested changes
Jan 31, 2025
| } | ||
| None => view! { <Toggle value=false on_change class name/> }.into_view(), | ||
| None => { | ||
| on_change.call(Value::Bool(false)); |
mahatoankitkumar
force-pushed
the
fix/toggle
branch
2 times, most recently
from
612a44c to
ee8e36b
Compare
ayushjain17
requested changes
Feb 3, 2025
| @@ -278,6 +278,9 @@ where | |||
| ) { | |||
| (Ok(schema_type), Ok(enum_variants)) => { | |||
| let input_type = InputType::from((schema_type.clone(), enum_variants)); | |||
| if input_type == InputType::Toggle { | |||
| config_value_ws.set(Value::Bool(false)); | |||
There was a problem hiding this comment.
this is also at render time
Datron
approved these changes
Feb 7, 2025
ayushjain17
requested changes
Feb 7, 2025
| @@ -278,6 +278,9 @@ where | |||
| ) { | |||
| (Ok(schema_type), Ok(enum_variants)) => { | |||
| let input_type = InputType::from((schema_type.clone(), enum_variants)); | |||
| if input_type == InputType::Toggle { | |||
| config_value_ws.set(Value::Bool(false)); | |||
Datron
added
bug
mahatoankitkumar
force-pushed
the
fix/toggle
branch
from
ee8e36b to
8b1bf63
Compare
Datron
approved these changes
Feb 10, 2025
ayushjain17
reviewed
Feb 10, 2025
Comment on lines
254
to
269
| if let (Ok(schema_type), Ok(enum_variants)) = ( | ||
| SchemaType::try_from(config_schema_rs.get()), | ||
| EnumVariants::try_from(config_schema_rs.get()), | ||
| ) { | ||
| if InputType::from((schema_type, enum_variants)) |
There was a problem hiding this comment.
are we not going to store it to optimise the repeated computations ?
mahatoankitkumar
force-pushed
the
fix/toggle
branch
from
8b1bf63 to
ad4f9e4
Compare
mahatoankitkumar
force-pushed
the
fix/toggle
branch
from
ad4f9e4 to
3c16c72
Compare
ayushjain17
reviewed
Feb 11, 2025
Comment on lines
257
to
259
| schema_type_ws | ||
| .set(SchemaType::try_from(type_schema.clone())); | ||
| enum_variants_ws.set(EnumVariants::try_from(type_schema)); |
There was a problem hiding this comment.
can we rather store in local variable and then set and then use the local variable in the subsequent lines
ShubhranshuSanjeev
previously requested changes
Feb 11, 2025
Comment on lines
257
to
268
| schema_type_ws | ||
| .set(SchemaType::try_from(type_schema.clone())); | ||
| enum_variants_ws.set(EnumVariants::try_from(type_schema)); | ||
| if let (Ok(schema_type), Ok(enum_variants)) = ( | ||
| schema_type_rs.get(), | ||
| enum_variants_rs.get(), | ||
| ) { |
There was a problem hiding this comment.
Please assign the value of schema type and enum variants to some variable and then use it set the signal and the if check.
Please refrain from setting the signal and then immediately reading from it.
mahatoankitkumar
force-pushed
the
fix/toggle
branch
from
3c16c72 to
fa15502
Compare
ayushjain17
approved these changes
Feb 11, 2025
Datron
dismissed
ShubhranshuSanjeev’s stale review
Comments were resolved. Please review again
ShubhranshuSanjeev
approved these changes
Feb 11, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The toggle component defaults to null instead of a boolean value when initially rendered, causing unexpected behavior until user interaction occurs.
Solution
Called the onChange event handler to properly handle the initial null state, ensuring the toggle always has a valid boolean value (true/false).