Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Incorrect paths for diffoscope comparison when Maven build not from root directory #1779

Open
algomaster99 opened this issue Feb 27, 2025 · 2 comments · May be fixed by #1817
Open

Incorrect paths for diffoscope comparison when Maven build not from root directory #1779

algomaster99 opened this issue Feb 27, 2025 · 2 comments · May be fixed by #1817
Labels
enhancement New feature or request for builspec/rebuild.sh help wanted Extra attention is needed

Comments

@algomaster99
Copy link
Contributor

When a rebuild is executed and there are bit-by-bit differences, the script outputs paths for manually execution diffoscope command.

# diffoscope target/reference/org.apache.orc/orc-1.8.3-source-release.zip target/orc-1.8.3-source-release.zip
# diffoscope target/reference/org.apache.orc/orc-shims-1.8.3-tests.jar shims/target/orc-shims-1.8.3-tests.jar
# diffoscope target/reference/org.apache.orc/orc-core-1.8.3-tests.jar core/target/orc-core-1.8.3-tests.jar
# diffoscope target/reference/org.apache.orc/orc-mapreduce-1.8.3-tests.jar mapreduce/target/orc-mapreduce-1.8.3-tests.jar
# diffoscope target/reference/org.apache.orc/orc-tools-1.8.3-tests.jar tools/target/orc-tools-1.8.3-tests.jar
# diffoscope target/reference/org.apache.orc/orc-examples-1.8.3-uber.jar examples/target/orc-examples-1.8.3-uber.jar
# diffoscope target/reference/org.apache.orc/orc-examples-1.8.3-tests.jar examples/target/orc-examples-1.8.3-tests.jar

However, if you cd content/org/apache/orc/buildcache/orc and then run these diffoscope commands, you get file does not exist error.
This happens because the root of this project (or where pom.xml) is at orc/java.
The solution to correction of these comments would be if all of these commands also respect -f java/pom.xml.

@hboutemy
Copy link
Member

hboutemy commented Feb 28, 2025

yes, known limitation: PR welcome, either at https://github.com/apache/maven-artifact-plugin level or reproducible-central's build_diffoscope.sh

@hboutemy hboutemy changed the title Incorrect paths for diffoscope comparison Incorrect paths for diffoscope comparison when Maven build not from root directory Feb 28, 2025
@algomaster99
Copy link
Contributor Author

Thanks! Will give it a try.

@hboutemy hboutemy added enhancement New feature or request for builspec/rebuild.sh help wanted Extra attention is needed labels Feb 28, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request for builspec/rebuild.sh help wanted Extra attention is needed
Development

Successfully merging a pull request may close this issue.

2 participants