Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Badge should be reset for unchecked new versions #201

Open
jskov opened this issue Sep 21, 2024 · 5 comments
Open

Badge should be reset for unchecked new versions #201

jskov opened this issue Sep 21, 2024 · 5 comments

Comments

@jskov
Copy link
Contributor

jskov commented Sep 21, 2024

Such as this

Or repo owners (and users) will get a false sense of security.

@hboutemy
Copy link
Member

we have auto-detection of new releases in place
I just added rebuild by CI in #202 when PR is provided
now I need to add auto-merge for a PR when result is 100% reproducible
and auto-creation of PRs

does it match your expectations?
do you have any other idea?
(this WE, I waited before doing the rebuild of your plugin because I was working on #202: I wanted to do #204 :)

@jskov
Copy link
Contributor Author

jskov commented Sep 24, 2024

Ah, ok. Makes sense to hold back builds to test something.

The idea I tried to communicate is that the badge data should (automatically) be something like (color:orange, text:unverified) when a new version has been found but not yet reproduced (whatever the reason).

Super idea in #202 btw.

Cheers!

@hboutemy
Copy link
Member

The idea I tried to communicate is that the badge data should (automatically) be something like (color:orange, text:unverified) when a new version has been found but not yet reproduced (whatever the reason).

any idea on how to trigger such a magic discovery and update of badge before auto-detection of new releases to do the rebuild?

@jskov
Copy link
Contributor Author

jskov commented Sep 25, 2024

Oh, no magic. You already detect the new release, and when I created this issue, the table row entry for mada-style was empty (except for the version).
That is all I meant; in that case, render unchecked badge.

Not that it should happen magically instantaneously on new releases in random projects 😀

@jskov
Copy link
Contributor Author

jskov commented Sep 26, 2024

How about this trick instead of magic; let the badge test include the tested version.

Then viewers will know if it applies to latest release, regardless of auto detection scheduling.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

No branches or pull requests

2 participants