Question: Split Makefile

[kuritka]

I can split makefile into multiple files using include keyword.
This way the split Makefile will still behave as one monolithic Makefile (the declared variable is visible from each Makefile, If I press tab in the commandline the autocomplete will work as expected).

Makefile is quite robust, do you think it makes sense to split it?

Example:

# Makefile

###############################################################################
# Target: codegen #
################################################################################
include tools/Makefile
################################################################################
# Target: docker #
################################################################################
include docker/Makefile
################################################################################
# Target: tests #
################################################################################
include tests/Makefile
```

[jkremser]

true, it's pretty complex. Crossplane folks have a standalone repo that they include as a git submodule - https://github.com/upbound/build But we are more a mono-repo project so not sure if it's not an overkill for us. So sub directories could work. I'd rather put all the makefile stuff into 1 directory rather than splitting them to {tools,docker,tests}/Makefile Perhaps something like build/Makefile.{tests,container,general,observability,playground..} ?

There is also that hack directory that was created by kubebuilder and that has only 1 file there, so it could go also there.

[kuritka]

Basically, the reason for moving Makefiles under individual folders was so that we could see only things related to tests in /test.

Although the idea of leaving everything in one folder is even better, especially more convenient for maintenance. So I'm in favor of leaving everything in /hack as you propose. 💯

Perhaps we can keep the master Makefile in root - containing include.

[ytsarev]

let's NOT do it until it's really necessary.