Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

git-commit-overflow does not see comments #1

Open
camsteffen opened this issue Dec 5, 2019 · 5 comments
Open

git-commit-overflow does not see comments #1

camsteffen opened this issue Dec 5, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@camsteffen
Copy link

image

This occurs in some scenarios like doing a squash commit. I added some garbage to the first line to better illustrate the issue.

Either beginning comments should be parsed, or if that's too complex, just disable git-commit-overflow functionality altogether when there are comments at the beginning.

@lenormf
Copy link
Member

lenormf commented Dec 8, 2019

The original implementation handled comments. But then the regex was very long, and I figured the main usecase was for single-commit messages, so simplified the code heavily.

I might revisit the regex to handle squashed commits.

@lenormf lenormf added the enhancement New feature or request label Dec 8, 2019
@camsteffen
Copy link
Author

Even in a simple git commit, the first line of comments is highlighted as "supposed to be blank". Maybe that case could be fixed more easily.

@th1j5
Copy link

th1j5 commented Jan 6, 2022

The original implementation handled comments.

Do you still have this one laying around? Because I didn't find it in the history of this repo and I'm also in search of those git-commit editor features (like mawww/kakoune#3228)

Edit: are you referring to mawww/kakoune#3228 (comment)? I didn't try everything out yet... Tried and is not handling comments.

@lenormf
Copy link
Member

lenormf commented Jan 7, 2022

I think that was the implementation, and that it broke after Kakoune stopped interpreting \A as the beginning of the buffer (or something).

@th1j5
Copy link

th1j5 commented Jan 7, 2022

Thanks! I'll see what I can do with it & learn more about highlighters in the process...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants