Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Set a sensible 3PID lookups validity period #123

Closed
maxidorius opened this issue Feb 11, 2019 · 1 comment
Closed

Set a sensible 3PID lookups validity period #123

maxidorius opened this issue Feb 11, 2019 · 1 comment
Assignees
Labels
enhancement Enhancement of existing feature/documentation
Milestone

Comments

@maxidorius
Copy link
Member

When computing the result of a 3PID lookup, we set a validity end time far in the future for the results. This is a problem for clients/servers that may implement actual caching, or for ourselves if we want to adding caching later for federated results.

We need to make this configurable with a sane default value like 1 day.

@maxidorius maxidorius added the enhancement Enhancement of existing feature/documentation label Feb 11, 2019
@maxidorius maxidorius added this to the v1.4.x milestone Feb 11, 2019
@maxidorius maxidorius modified the milestones: v1.4, v1.x Mar 14, 2019
@maxidorius maxidorius changed the title Make 3PID lookups validity period configurable Set a sensible 3PID lookups validity period May 30, 2019
@maxidorius maxidorius self-assigned this May 30, 2019
@maxidorius
Copy link
Member Author

After evaluation, we do not have a good, central place in code where this could be set/enforced, we'll therefore only set a sensible validity period of 1 min before and 5 min after the lookup.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement Enhancement of existing feature/documentation
Projects
None yet
Development

No branches or pull requests

1 participant