From 98bfd65d560fa71ce41fd565dce6f9af283bcb94 Mon Sep 17 00:00:00 2001 From: Kamil Kisiela Date: Sun, 18 Nov 2018 22:08:04 +0100 Subject: [PATCH] Revert "Serve command (#3)" This reverts commit 3cf654652dee6e73c04b27858819f7f30d305d1d. --- example/package.json | 1 - package.json | 3 --- src/cli.ts | 6 ------ src/cli/commands/serve.ts | 39 --------------------------------------- tsconfig.json | 1 - 5 files changed, 50 deletions(-) delete mode 100644 src/cli/commands/serve.ts diff --git a/example/package.json b/example/package.json index 23ffeba2b6..70e04351cc 100644 --- a/example/package.json +++ b/example/package.json @@ -8,7 +8,6 @@ "similar": "node ../dist/cli.js similar ./schemas/similar.graphql", "similar:type": "node ../dist/cli.js similar ./schemas/similar.graphql --type Post", "similar:loose": "node ../dist/cli.js similar ./schemas/similar.graphql --threshold 0.1", - "serve": "node ../dist/cli.js serve ./schemas/schema.graphql", "open-help": "node ../dist/cli.js --help" } } diff --git a/package.json b/package.json index fdd723de22..39193d73c8 100644 --- a/package.json +++ b/package.json @@ -43,7 +43,6 @@ "@types/jest": "23.3.9", "@types/log-symbols": "2.0.0", "@types/node-fetch": "2.1.3", - "@types/opn": "5.1.0", "@types/string-similarity": "1.2.0", "graphql": "14.0.2", "graphql-tag": "2.10.0", @@ -54,7 +53,6 @@ "typescript": "3.1.6" }, "dependencies": { - "apollo-server": "2.2.2", "chalk": "2.4.1", "commander": "2.19.0", "glob": "7.1.3", @@ -62,7 +60,6 @@ "is-valid-path": "0.1.1", "log-symbols": "2.2.0", "node-fetch": "2.3.0", - "opn": "5.4.0", "string-similarity": "2.0.0" } } diff --git a/src/cli.ts b/src/cli.ts index 18249c2244..edf64acddf 100644 --- a/src/cli.ts +++ b/src/cli.ts @@ -5,7 +5,6 @@ import * as commander from 'commander'; import {diff} from './cli/commands/diff'; import {validate} from './cli/commands/validate'; import {similar} from './cli/commands/similar'; -import {serve} from './cli/commands/serve'; commander .command('diff ') @@ -26,9 +25,4 @@ commander similar(schema, cmd.type, cmd.threshold); }); -commander - .command('serve ') - .description('Serves a GraphQL API with GraphQL Playground') - .action(serve); - commander.parse(process.argv); diff --git a/src/cli/commands/serve.ts b/src/cli/commands/serve.ts deleted file mode 100644 index 85fccb90e3..0000000000 --- a/src/cli/commands/serve.ts +++ /dev/null @@ -1,39 +0,0 @@ -import * as logSymbols from 'log-symbols'; -import chalk from 'chalk'; -import {ApolloServer} from 'apollo-server'; -import opn = require('opn'); - -import {loadSchema} from '../loaders/schema'; -import {Renderer, ConsoleRenderer} from '../render'; - -export async function serve( - schemaPointer: string, - options?: { - renderer?: Renderer; - }, -) { - const renderer = (options && options.renderer) || new ConsoleRenderer(); - const schema = await loadSchema(schemaPointer); - const PORT = process.env.PORT || '4000'; - const app = new ApolloServer({ - cors: true, - mocks: true, - playground: true, - schema, - }); - - try { - const {url} = await app.listen(PORT); - - renderer.emit( - chalk.greenBright( - logSymbols.success, - `Serving the GraphQL Playground on ${url}`, - ), - ); - - await opn(url); - } catch (e) { - renderer.emit(chalk.redBright(logSymbols.error, e.message || e)); - } -} diff --git a/tsconfig.json b/tsconfig.json index 852304ba9d..4143f3d8ed 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -12,7 +12,6 @@ "noUnusedParameters": true, "moduleResolution": "node", - "allowSyntheticDefaultImports": true, "baseUrl": "./", "types": [], "lib": [