-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Windows 10 package.json config #165
Comments
I think the Makefile issue is a bit separate, because that might be more difficult to port to Windows. The env variable thing might not even be required, so perhaps I should just remove it. You have already fixed and tested your modifications to package.json, correct? If so, are you willing to create a Pull Request with your modifications? :-) It'd be thankful for your contribution. |
I'm guessing there's a way to have operating-system specific variations in the toolchain, just don't know what they are. Better way I guess would be something like gulp to cope with the Makefile actions and the ENV variables I suppose. ENV support is vital IMHO I don't know if my Windows-only package.json script will work elsewhere -doubt it. |
The Makefile is only used for updating the automatically generated documentation. Once it's stable enough, I believe it should rarely if ever be run manually. Instead, it should be executed by Travis CI. Therefore, Windows support might not be a priority, but it would indeed be nice to have. package.json should work everywhere. I believe your changes are probably not breaking it on Linux |
OK, here's the pacakge.json PR: zawsx#1 |
@zawsx pls submit pull request to this repo, not the fork :-) |
Had to remove the single quotes around './src/index.js' in package.json for it to work under windows - here's them removed:
"manual-test": "webpack-dev-server ./src/index.js --hot --inline --output-filename 'bundle.js'"
env variable assignments in package.json scripts don't work out of the box in W10 on mine. WEBPACK_ENV for instance.
The Makefile won't work under windows as make isn't native so the examples docs can't be compiled.
The text was updated successfully, but these errors were encountered: