Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(config): upgrade to ^lodash: 4.2.1 #178

Closed
wants to merge 1 commit into from

Conversation

webben-de
Copy link

so the dependence is not longer deprecated

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@dignifiedquire
Copy link
Member

Thanks, could you please change the commit message to follow our convention?

@webben-de webben-de changed the title update to lodash ^4.2.1 chore(config): upgrade to ^lodash: 4.2.1 Feb 9, 2016
@webben-de
Copy link
Author

sure, like that?
I'm not really sure, how to edit the body of the commit.

@googlebot
Copy link

CLAs look good, thanks!

@julkue
Copy link
Contributor

julkue commented Feb 16, 2016

@geisslercom reset the branch and do your changes with correct commit messages again.

@dignifiedquire
Copy link
Member

@geisslercom you can use git commit --amend to change the message of the last commit

@dignifiedquire
Copy link
Member

Afterwards you'll need to git push -f <remote> <branchname>

@dignifiedquire
Copy link
Member

@geisslercom one more thing, looks like there is merge conflict now. Could you rebase onto the latests master please (git fetch <remote> && git rebase <remote>/master)

dignifiedquire added a commit that referenced this pull request Jun 26, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants