fix: properly format err messages with new lines

Fixes #40
karma-runner · Aug 22, 2014 · 1144690 · 1144690
1 parent b4ee7f2
commit 1144690
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/adapter.js b/src/adapter.js
@@ -3,8 +3,7 @@ var formatError = function(error) {
   var message = error.message;
 
   if (stack) {
-    var firstLine = stack.substring(0, stack.indexOf('\n'));
-    if (message && firstLine.indexOf(message) === -1) {
+    if (message && stack.indexOf(message) === -1) {
       stack = message + '\n' + stack;
     }
 

diff --git a/test/adapter.spec.js b/test/adapter.spec.js
@@ -342,4 +342,16 @@ describe('adapter mocha', function() {
       expect(createConfigObject(this.karma).globals).to.deep.eq(['__cov', 'test']);
     });
   });
+
+  describe('formatError', function () {
+
+    it('should properly format exceptions that contains \n in their message', function () {
+      var errLines = formatError(new Error('foo\nbar')).split('\n');
+      expect(errLines[0]).to.contain('foo');
+      expect(errLines[1]).to.equal('bar');
+      expect(errLines[2]).to.not.contain('foo');
+      expect(errLines[3]).to.not.contain('bar');
+    });
+
+  });
 });