fix(file-list): do not define fs.statAsync #3467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defining fs.statAsync affects other modules such as bluebird which throws an error because of the 'Async'-suffix: > Cannot promisify an API that has normal methods with 'Async'-suffix > See http://goo.gl/MqrFmX Fixes: karma-runner#3466
|
✅ Build karma 2575 completed (commit 3419c2ebd1 by @matz3) |
|
✅ Build karma 176 completed (commit 3419c2ebd1 by @matz3) |
|
✅ Build karma 177 completed (commit 3419c2ebd1 by @matz3) |
devoto13
approved these changes
Apr 9, 2020
|
retry |
|
✅ Build karma 182 completed (commit 26e7b27a80 by @matz3) |
|
✅ Build karma 181 completed (commit 26e7b27a80 by @matz3) |
|
✅ Build karma 2580 completed (commit 26e7b27a80 by @matz3) |
|
Ok so now the travis integration point is broken. I will force this PR, and see if we get a release. |
karmarunnerbot
pushed a commit
that referenced
this pull request
Apr 10, 2020
## [5.0.1](v5.0.0...v5.0.1) (2020-04-10) ### Bug Fixes * **file-list:** do not define fs.statAsync ([#3467](#3467)) ([55a59e7](55a59e7))
|
🎉 This PR is included in version 5.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
anthony-redFox
pushed a commit
to anthony-redFox/karma
that referenced
this pull request
May 16, 2023
Defining fs.statAsync affects other modules such as bluebird which throws an error because of the 'Async'-suffix: > Cannot promisify an API that has normal methods with 'Async'-suffix > See http://goo.gl/MqrFmX Fixes: karma-runner#3466
anthony-redFox
pushed a commit
to anthony-redFox/karma
that referenced
this pull request
May 16, 2023
## [5.0.1](karma-runner/karma@v5.0.0...v5.0.1) (2020-04-10) ### Bug Fixes * **file-list:** do not define fs.statAsync ([karma-runner#3467](karma-runner#3467)) ([55a59e7](karma-runner@55a59e7))
This was referenced Jan 1, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining fs.statAsync affects other modules such as bluebird which
throws an error because of the 'Async'-suffix:
Fixes: #3466