Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature request] Allow hide urls from the plot #19

Closed
BrikerMan opened this issue Oct 28, 2020 · 7 comments · Fixed by #26
Closed

[Feature request] Allow hide urls from the plot #19

BrikerMan opened this issue Oct 28, 2020 · 7 comments · Fixed by #26
Labels
enhancement New feature or request

Comments

@BrikerMan
Copy link

Thanks for the great framework, it helps a lot. But I need to hide the URLs from the plot so I can focus on the images. Cab we add that feature?

@karolzak
Copy link
Owner

Hi @BrikerMan
It makes perfect sense to me. I'll put this in the backlog - thanks!

@karolzak karolzak added the enhancement New feature or request label Oct 28, 2020
@Maarten-vr
Copy link
Contributor

Hi @karolzak, is there any progress on this topic or is there a quick workaround?
It is a nice package for convenience, but the url are making the output quite messy in my case.

@karolzak
Copy link
Owner

karolzak commented Dec 9, 2020

Hey @Maarten-vr
Was busy with other stuff lately so this feature got buried and forgotten but since it's a minor enhancement I will try to add it before the winter holidays

@Maarten-vr
Copy link
Contributor

I've dug into the code myself as well and made it work.
I've created a PR so you can use the code (either directly, or improve upon it)

@karolzak
Copy link
Owner

karolzak commented Dec 9, 2020

@Maarten-vr that's a rockstar move!
Thank you so much for this contribution! I will review it and merge ASAP!

@karolzak karolzak linked a pull request Dec 9, 2020 that will close this issue
@karolzak
Copy link
Owner

Thanks @BrikerMan for this suggestion and thank you @Maarten-vr for implementing it!
This feature is now available in version 1.1.1

@Alyetama
Copy link
Contributor

Alyetama commented May 8, 2021

Thanks @BrikerMan for this suggestion and thank you @Maarten-vr for implementing it!
This feature is now available in version 1.1.1

Just FYI, version 1.1.1 is not on PyPi yet.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants