Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

github ci: pin zig version to 0.13.0 (for now) #43

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

floooh
Copy link
Collaborator

@floooh floooh commented Dec 20, 2024

Just a quick fix to make the CI work again.

I already fixed the build.zig files in sokol-zig and dcimgui to work both with the latest 0.14.x changes (e.g. for dcimgui just pull the latest version instead of 1.91.6, and check sokol-zig's build.zig updates.

(let me know if you want me to integrate those changes into sokol-d/build.zig or if you want to do that yourself) :)

@floooh floooh requested a review from kassane December 20, 2024 17:08
@kassane
Copy link
Owner

kassane commented Dec 20, 2024

I have read some of the questions you asked about refactored build.zig redundancies.
However, is there any problem with keeping the master?
like floooh/sokol-zig@a26bb7c

@floooh
Copy link
Collaborator Author

floooh commented Dec 20, 2024

That commit didn't work, the new version looks like this (the if-block is the old version for 0.13.0, and the much simpler else-block is for the current Zig nightly):

https://github.com/floooh/sokol-zig/blob/9d113214f7750f8ab68b465b2605ce308e995fb4/build.zig#L365-L390

...that would be the 'proper' solution of course (instead of pinning the CI to 0.13.0). E.g. feel free to close this PR if you want to fix build.zig instead.

@floooh
Copy link
Collaborator Author

floooh commented Dec 20, 2024

Ah, let me just fix the build.zig instead one sec ;) New PR incoming.

@floooh floooh closed this Dec 20, 2024
@floooh
Copy link
Collaborator Author

floooh commented Dec 20, 2024

I'll also fix the dcimgui dependency... because that has another breaking change.

@floooh
Copy link
Collaborator Author

floooh commented Dec 20, 2024

...oh there's multiple places to fix in the sokol-d/build.zig...

@floooh
Copy link
Collaborator Author

floooh commented Dec 20, 2024

Ooof, there's a lot more things to fix for Zig 0.14.x, especially when it needs to run both on 0.13 and 0.14. I'll reopen the PR and leave the build.zig changes to you :)

I think it's better to just pin the CI to 0.13.0 for now.

PS: e.g. one other thing that needs fixing is the addArtifact() helper function, since the .root_module Options member is now a pointer.

@floooh floooh reopened this Dec 20, 2024
@kassane kassane merged commit 98f8c03 into main Dec 20, 2024
3 checks passed
@kassane kassane deleted the github-ci-use-zig-0.13.0 branch December 20, 2024 17:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants