Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Provide guidance how to build an external scaler #104

Closed
tomkerkhove opened this issue Mar 5, 2020 · 8 comments
Closed

Provide guidance how to build an external scaler #104

tomkerkhove opened this issue Mar 5, 2020 · 8 comments
Assignees
@ahmelsayed
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@tomkerkhove
Copy link
Member

Our current external scaler docs are very basic, we should enrich them in what it requires to be an external scaler.

Things it should cover are:

  • What does it need to expose
  • What are the data contracts that are required
  • ..

Providing an OpenAPI spec for this might be a good option?
@tomkerkhove tomkerkhove added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 5, 2020
@tomkerkhove
Copy link
Member Author

@ahmelsayed @TsuyoshiUshio can you give some insights on this?

@tomkerkhove
Copy link
Member Author

@ahmelsayed @zroubalik Can you guys help with this? What does it take to be a good external scaler?

If we have that, I can provide an OpenAPI spec to comply with.

@tomkerkhove
Copy link
Member Author

Apparently protobuf schema is the way to go for gRPC, added issue on kedacore/external-scalers#3 to provide one

@tomkerkhove tomkerkhove self-assigned this Jun 4, 2020
@tomkerkhove
Copy link
Member Author

@ahmelsayed Can you pick this up given we have a lot of questions about this?

@ahmelsayed
Copy link
Contributor

Yes I'll take this.

@ahmelsayed ahmelsayed self-assigned this Jul 17, 2020
@tomkerkhove tomkerkhove removed their assignment Jul 17, 2020
@tomkerkhove tomkerkhove mentioned this issue Jul 27, 2020
Closed
@tomkerkhove
Copy link
Member Author

Done for 2.0 in #193, previous version to follow

@ahmelsayed
Copy link
Contributor

This is done for 1.5 and 1.4 in #221

@tomkerkhove
Copy link
Member Author

Thanks @ahmelsayed !

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ahmelsayed ahmelsayed

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahmelsayed @tomkerkhove