Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature Suggestion: Make GammaToLinearSpace Conversion Optional in the Shader #85

Open
strangerattractor opened this issue Apr 2, 2022 · 1 comment
Assignees
Labels

Comments

@strangerattractor
Copy link

strangerattractor commented Apr 2, 2022

Reason being:

I tried to spout Positional Data from TouchDesigner to Unity.
GammaToLinearSpace Conversion in your shader leads to this behaviour:

https://streamable.com/kjz7si

Bypassing Line 52 in your shader fixes the issue for me:
#ifndef UNITY_COLORSPACE_GAMMA c.rgb = GammaToLinearSpace(c.rgb); #endif

here is a proof of concept video:
https://streamable.com/goojr6
(I only bypassed the gamma correction directly in the shadercode. Nothing else. Very messy)

Thanks for your awesome work!

@keijiro keijiro self-assigned this Apr 3, 2022
@strangerattractor
Copy link
Author

Hi Keijiro,

saw that you changed this into "question". Am I missing something?
I figured out that I can also switch Unity to "Gamma Mode", which also changes the behavior of the shader, and makes it work.
But that in turn "breaks" the standard HDRP-Settings.

I'm thankful for any guidance you can give on this.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants