fix: undo semver breaking globby update #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Isn't it "Require Node.js 10", you mean Node.js 8? |
|
Good catch. updated to "Globby 11 drops node 8" |
keithamus
reviewed
May 3, 2020
keithamus
approved these changes
May 3, 2020
|
🎉 This PR is included in version 1.42.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't figure out what Node versions you support or if you use semver, but this came up in a couple projects. Globby 11 drops node 8, and this project was not major version bumped.
https://github.com/keithamus/sort-package-json/pull/161/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R77
https://github.com/sindresorhus/globby/releases/tag/v11.0.0