Client/Server middleware does not follow Sidekiq's middleware docs for v7+ #35
gabriel-lima
started this conversation in
General
Replies: 0 comments
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
-
Hi, I am new in the sidekiq-status codebase.
I was reading Sidekiq docs to upgrade to v7+ and noticed this following docs:
https://github.com/sidekiq/sidekiq/blob/main/docs/middleware.md
Looking into https://github.com/kenaniah/sidekiq-status/blob/main/lib/sidekiq-status/client_middleware.rb and https://github.com/kenaniah/sidekiq-status/blob/main/lib/sidekiq-status/server_middleware.rb I wasn't able to find their recommendation in code.
I don't have any issue, just curious to know if that would cause any problem between Sidekiq and Sidekiq Status.
Thank you
Beta Was this translation helpful? Give feedback.
All reactions