Skip to content
This repository has been archived by the owner on Jan 6, 2021. It is now read-only.

check for sigint before setting exit code to 1 - Fixes #180 #181

Merged
merged 1 commit into from
May 22, 2018
Merged

check for sigint before setting exit code to 1 - Fixes #180 #181

merged 1 commit into from
May 22, 2018

Conversation

jnielson94
Copy link
Contributor

What:
Fix #180. Change logic in child process exit listener to the following:

  1. Default to the exit code passed in
  2. Default to exit code 0 if exit code is null but signal was SIGINT
  3. Default to exit code 1 otherwise

How:
See #180 for documentation of how fix was found/decided on.

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged
  • Added myself to contributors table

I couldn't get the precommit hooks to work, but I ran validate, build, test, and manually used the all-contributors-cli to add myself to that section.

@kentcdodds I didn't feel like this needed any documentation outside of the code, feel free to point me where some could be used if there is a place.

@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

Merging #181 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #181   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          65     68    +3     
  Branches       16     17    +1     
=====================================
+ Hits           65     68    +3
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb37984...8fbe944. Read the comment docs.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thank you very much :) Sorry about the trouble with kcd-scripts and all-contributors.

@kentcdodds kentcdodds merged commit b88977c into kentcdodds:master May 22, 2018
This was referenced Sep 13, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPM Script Ctrl/Cmd + C Errors
2 participants