Ignore extra whitespace in node texts #21
Conversation
src/queries.js
Outdated
| @@ -173,6 +171,7 @@ export { | |||
| queryByPlaceholderText, | |||
| getByPlaceholderText, | |||
| queryByText, | |||
| getText, | |||
There was a problem hiding this comment.
This file should only expose queries. Other utilities should live in other files. Could you move getText to its own file?
There was a problem hiding this comment.
Got it. Also, I wonder if we should publicly call it getNodeText instead?
There was a problem hiding this comment.
Agreed. We can rename it to getNodeText 👍
README.md
Outdated
| // Hello | ||
| // World ! | ||
| // </div> | ||
| const text = getNodeText(container.querySelector('div')) // "Hello World!" |
There was a problem hiding this comment.
Shouldn't this be: "Hello World !" ?
|
This looks unrelated, and perhaps there's a brittle test in the wait-for-element part. I just ran |
|
BTW (unrelated but) have you considered adding |
|
I've restarted the build. Yes, that's odd. Hmmm...
I have not! Hmmm... I wonder if I could make it interactive. If there are snapshot differences, ask the user if they'd like to cancel the commit or update them... Not sure that'd be possible with lint-staged though... |
|
The restarted build passed! 😱 |
|
Uh oh... We should probably look into that. |
* added waitForExpect with test * added typescript and simplified version of the waitForExpect, used and exports its typings * added initial notes about waitForExpect * fixed styling * minor stylistic change * updated tests to remove the nesting * updated readme * fixed d .md syntax * improved style Closes testing-library#21
As discussed in testing-library/jest-dom#9 (comment)