Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

fix: Change name label to respect the nameOverride #8249

Merged
merged 5 commits into from
Jul 4, 2022

Conversation

mowies
Copy link
Member

@mowies mowies commented Jun 29, 2022

This PR

  • fixes a bug that prevented user from configuring multiple execution planes by allowing users to override the name of helm/jmeter svc which in turn puts the services into separate pubsub groups in NATS

Fixes #8055
Integration test run: https://github.com/keptn/keptn/actions/runs/2590089094

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #8249 (5ea6bd3) into master (6a0e1be) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8249   +/-   ##
=======================================
  Coverage   62.93%   62.93%           
=======================================
  Files         627      627           
  Lines       33543    33543           
  Branches     1637     1637           
=======================================
  Hits        21109    21109           
  Misses      11135    11135           
  Partials     1299     1299           
Flag Coverage Δ
helm-service 47.57% <ø> (ø)
jmeter-service 25.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies added the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label Jun 30, 2022
@mowies mowies force-pushed the fix/8055/add-name-override branch from fafc2b3 to 5104e17 Compare June 30, 2022 11:33
mowies added 4 commits June 30, 2022 14:59
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies force-pushed the fix/8055/add-name-override branch from 5104e17 to bbcf34e Compare June 30, 2022 12:59
@mowies mowies marked this pull request as ready for review June 30, 2022 13:26
@mowies mowies requested a review from a team as a code owner June 30, 2022 13:26
@mowies mowies removed the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label Jun 30, 2022
thisthat
thisthat previously approved these changes Jul 1, 2022
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies merged commit 6f6af8b into master Jul 4, 2022
@mowies mowies deleted the fix/8055/add-name-override branch July 4, 2022 08:21
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot register additional Execution Planes on Multi-cluster setup
2 participants