Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update method doesn't trigger in IE11 #43

Closed
mikestreety opened this issue Oct 30, 2017 · 5 comments
Closed

Update method doesn't trigger in IE11 #43

mikestreety opened this issue Oct 30, 2017 · 5 comments

Comments

@mikestreety
Copy link

mikestreety commented Oct 30, 2017

Hey,

I'll come back and properly fill out this issue this afternoon, but thought I would just put it here before I forget.

The this.update method doesn't seem to ever get fired in IE11 or below. However the this.process one does.

I have temporarily updated the this.process method to the following (i expanded the if statements while I was debugging) and remove the update method

/**
* Validate value before update the component.
* @param {Number} value
*/
process: function(value) {
	if (value >= this.max) {
		value = this.max;
	}
	if (value <= this.min) {
		value = this.min;
	}
	if (!this.minus && value < 0) {
		value = this.min >= 0 ? this.min: 0;
	}

	this.$emit('input', Number(accounting.toFixed(value, this.precision)));
},
@mikestreety mikestreety changed the title Process method doesn't work in IE11 Update method doesn't trigger in IE11 Oct 30, 2017
@kevinongko
Copy link
Owner

Hi @mikestreety,

I tried the live demo with IE11, and it's works correctly, could you give steps to reproduce?
Thanks

@mikestreety
Copy link
Author

mikestreety commented Nov 3, 2017

Thanks for getting back to me. This pen, in IE11, doesn't work for me in IE11

https://codepen.io/mikestreety/pen/aLgMPM

Video: http://recordit.co/0sJs5eLcJj

@mikestreety
Copy link
Author

mikestreety commented Nov 3, 2017

But the live demo (https://kevinongko.github.io/vue-numeric/) does work 🤔

@tjrchampion
Copy link

Any follow up on this? Experiencing the exact same problem in IE 11.

@kevinongko
Copy link
Owner

Fixed in 2.2.7

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants