Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Proposal: Parity between bot functions and Keybase API names #25

Open
nathanmsmith opened this issue Aug 23, 2019 · 0 comments
Open

Proposal: Parity between bot functions and Keybase API names #25

nathanmsmith opened this issue Aug 23, 2019 · 0 comments

Comments

@nathanmsmith
Copy link

Many of the names and functions that the go bot uses are very specific. Examples:

  • GetTextMessages (all other message types are ignored)
  • SendAttachmentByTeam

Rather than have specific functions for cases like these, I think it'd make more sense to have more general options that map 1-to-1 to the functions exposed to us by the underlying Keybase API. The TypeScript bot is a good example of this; the functionality for the above functions is implemented via read and attach, respectively.

That being said, I think there are some methods like SendMessageByTlfName that save the creation of a lot of new channel objects. Since the bot types will require a major version upgrade, I'm opening this issue to start a discussion on what function signatures it'd make sense to change in a v2.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant