From 761dcb242b44c993d3653a4a320f251e2026f471 Mon Sep 17 00:00:00 2001 From: Justin Swart Date: Mon, 11 May 2020 16:36:21 -0700 Subject: [PATCH] Fix landscape and SE bug --- .../Controllers/PledgeAmountViewController.swift | 2 +- .../Views/Controllers/PledgeViewController.swift | 11 +++++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/Kickstarter-iOS/Views/Controllers/PledgeAmountViewController.swift b/Kickstarter-iOS/Views/Controllers/PledgeAmountViewController.swift index a40569e621..f6b22c58c4 100644 --- a/Kickstarter-iOS/Views/Controllers/PledgeAmountViewController.swift +++ b/Kickstarter-iOS/Views/Controllers/PledgeAmountViewController.swift @@ -144,7 +144,7 @@ final class PledgeAmountViewController: UIViewController { } } - override func didMove(toParent parent: UIViewController?) { + override func didMove(toParent _: UIViewController?) { self.verticalSpacer.isHidden = true } diff --git a/Kickstarter-iOS/Views/Controllers/PledgeViewController.swift b/Kickstarter-iOS/Views/Controllers/PledgeViewController.swift index 26745d87f3..78e1b905c9 100644 --- a/Kickstarter-iOS/Views/Controllers/PledgeViewController.swift +++ b/Kickstarter-iOS/Views/Controllers/PledgeViewController.swift @@ -170,6 +170,14 @@ final class PledgeViewController: UIViewController, self.sessionStartedObserver.doIfSome(NotificationCenter.default.removeObserver) } + override func viewDidAppear(_ animated: Bool) { + super.viewDidAppear(animated) + + // Works around a layout bug when in landscape or on iPhone SE - last observed on iOS 13.4. + self.addChild(self.paymentMethodsViewController) + self.paymentMethodsViewController.didMove(toParent: self) + } + // MARK: - Configuration private func configureChildViewControllers() { @@ -189,8 +197,7 @@ final class PledgeViewController: UIViewController, self.pledgeAmountViewController, self.pledgeAmountSummaryViewController, self.shippingLocationViewController, - self.summaryViewController, - self.paymentMethodsViewController + self.summaryViewController ] let arrangedSubviews = [