From 6c369f8e42aaf950e97eeebf5d050e5557f2af81 Mon Sep 17 00:00:00 2001 From: Justin Swart Date: Wed, 30 Sep 2020 16:39:52 -0700 Subject: [PATCH 1/2] Use correct lane names, read-only match on CI --- .circleci/config.yml | 4 ++-- .fastlane/Fastfile | 10 ++++++---- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index cccc792815..58a54c3121 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -238,7 +238,7 @@ jobs: <<: *distribute_job environment: - *default_environment - - LANE=alpha_match_gym_appcenter_s3 + - LANE=alpha_match_gym_appcenter - FIREBASE_DIR=Firebase-Alpha - DSYMS_FILE=KickAlpha.app.dSYM.zip @@ -274,7 +274,7 @@ jobs: <<: *distribute_job environment: - *default_environment - - LANE=itunes_match_gym_appcenter_s3 + - LANE=itunes_match_gym_deliver - FIREBASE_DIR=Firebase-Production - DSYMS_FILE=Kickstarter.app.dSYM.zip diff --git a/.fastlane/Fastfile b/.fastlane/Fastfile index b61082c245..4be17be8c6 100644 --- a/.fastlane/Fastfile +++ b/.fastlane/Fastfile @@ -20,7 +20,8 @@ platform :ios do git_url: "https://github.com/kickstarter/ios-certificates", team_id: "48YBP49Y5N", git_branch: "ksr", - username: ENV["ITUNES_CONNECT_ACCOUNT"] + username: ENV["ITUNES_CONNECT_ACCOUNT"], + readonly: is_ci ) end @@ -36,7 +37,8 @@ platform :ios do team_id: "48YBP49Y5N", git_branch: "ksr", username: ENV["ITUNES_CONNECT_ACCOUNT"], - force_for_new_devices: true + force_for_new_devices: true, + readonly: is_ci ) end @@ -52,7 +54,8 @@ platform :ios do team_id: "5DAN4UM3NC", git_branch: "ksr-enterprise", username: ENV["ITUNES_CONNECT_ACCOUNT"], - force_for_new_devices: true + force_for_new_devices: true, + readonly: is_ci ) end @@ -126,7 +129,6 @@ platform :ios do desc "Upload to the App Store" lane :itunes_deliver do - deliver( force: true, username: ENV["ITUNES_CONNECT_ACCOUNT"], From 5d8d561231448169322068f9688a74e43946d222 Mon Sep 17 00:00:00 2001 From: Justin Swart Date: Wed, 30 Sep 2020 17:07:28 -0700 Subject: [PATCH 2/2] Remove read-only on CI --- .fastlane/Fastfile | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/.fastlane/Fastfile b/.fastlane/Fastfile index 4be17be8c6..b9985691a0 100644 --- a/.fastlane/Fastfile +++ b/.fastlane/Fastfile @@ -20,8 +20,7 @@ platform :ios do git_url: "https://github.com/kickstarter/ios-certificates", team_id: "48YBP49Y5N", git_branch: "ksr", - username: ENV["ITUNES_CONNECT_ACCOUNT"], - readonly: is_ci + username: ENV["ITUNES_CONNECT_ACCOUNT"] ) end @@ -37,8 +36,7 @@ platform :ios do team_id: "48YBP49Y5N", git_branch: "ksr", username: ENV["ITUNES_CONNECT_ACCOUNT"], - force_for_new_devices: true, - readonly: is_ci + force_for_new_devices: true ) end @@ -54,8 +52,7 @@ platform :ios do team_id: "5DAN4UM3NC", git_branch: "ksr-enterprise", username: ENV["ITUNES_CONNECT_ACCOUNT"], - force_for_new_devices: true, - readonly: is_ci + force_for_new_devices: true ) end