Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deactivate menu entries when not actionable #1318

Open
kelson42 opened this issue Jan 2, 2025 · 5 comments · May be fixed by #1337
Open

Deactivate menu entries when not actionable #1318

kelson42 opened this issue Jan 2, 2025 · 5 comments · May be fixed by #1337
Assignees
Milestone

Comments

@kelson42
Copy link
Collaborator

kelson42 commented Jan 2, 2025

In the following menu and sub menu, when on the library, we have many items which are actionable/clickable but which do nothing and no sense outside the context of an article. They should be deactivated (many are already)... and reactivated when an article tab is open
Image

@kelson42 kelson42 added this to the 2.5.0 milestone Jan 2, 2025
@siya100
Copy link

siya100 commented Feb 1, 2025

hey @kelson42 can you assign this issue to me

@etude11
Copy link

etude11 commented Feb 7, 2025

Hey @kelson42, regarding the issue you raised, I have a question based on my understanding:
Should all the unnecessary menu and submenu options be greyed out and non-clickable, or should they be completely removed (hidden) from the menu?

@kelson42
Copy link
Collaborator Author

kelson42 commented Feb 7, 2025

only greyed, part of them are already greyed properly.

@etude11
Copy link

etude11 commented Feb 7, 2025

Thanks for the clarification, @kelson42 !
I'll proceed accordingly. Let me know if there's anything else you'd like me to consider.

@etude11
Copy link

etude11 commented Feb 8, 2025

I've submitted a pull request, please look a it!

Thank you

@kelson42 kelson42 linked a pull request Feb 8, 2025 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants