Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deliver proper ZIM "favicon" for screens with dpr > 1 #716

Open
kelson42 opened this issue Nov 2, 2024 · 2 comments
Open

Deliver proper ZIM "favicon" for screens with dpr > 1 #716

kelson42 opened this issue Nov 2, 2024 · 2 comments
Assignees
Milestone

Comments

@kelson42
Copy link
Contributor

kelson42 commented Nov 2, 2024

More and more screens have a (device pixel ratio) > 1. Unfortunately on these screens, our current favicon delivered by ZIM Metadta `Illustration_48x48@1" does not deliver enough information to be displayed properly.

Based on the dpr value delivered by the Web browser, kiwix-serve should use Illustration_48x48@1", Illustration_48x48@4" or `Illustration_48x48@3" (this list is not exhaustive).

Blocked by openzim/libzim#937

@kelson42
Copy link
Contributor Author

kelson42 commented Nov 2, 2024

@rgaudin agree how this should work?

@kelson42 kelson42 changed the title Deliver ZIM "favicon" for screens with dpr > 1 Deliver proper ZIM "favicon" for screens with dpr > 1 Nov 2, 2024
@rgaudin
Copy link
Member

rgaudin commented Nov 2, 2024

@rgaudin agree how this should work?

I think we should simply list all available illustration variants with their respective DPR for the browser to decide ; yes.

I dont understand what this is doing in kiwix-tools though as this is libkiwix.

@kelson42 kelson42 modified the milestones: 3.9.0, 3.8.0 Dec 25, 2024
@kelson42 kelson42 modified the milestones: 3.8.0, 3.9.0 Feb 9, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants