feat: refactor Notion database querying methods #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a new method `QueryContainsDatabase` to query the Notion database by property and value - Move the `notionapi.NewClient` initialization to a separate variable `client` - Modify the `QueryContainsDatabase` method to add the `UId` to the filter conditions - Add a new method `QueryDatabaseContainsByName` to query the Notion database by name and UId - Add a new method `QueryDatabaseContainsByEmail` to query the Notion database by email and UId - Add a new method `QueryDatabaseContainsByTitle` to query the Notion database by title and UId - Add a new method `QueryDatabaseContains` to query the Notion database by name, email, and title Signed-off-by: Evan Lin <evan.if.lin@linecorp.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueryContainsDatabaseto query the Notion database by property and valuenotionapi.NewClientinitialization to a separate variableclientQueryContainsDatabasemethod to add theUIdto the filter conditionsQueryDatabaseContainsByNameto query the Notion database by name and UIdQueryDatabaseContainsByEmailto query the Notion database by email and UIdQueryDatabaseContainsByTitleto query the Notion database by title and UIdQueryDatabaseContainsto query the Notion database by name, email, and title