Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding aria-labels, ids to public forms for accessibility #697

Closed
candideu opened this issue Feb 13, 2022 · 1 comment
Closed

Adding aria-labels, ids to public forms for accessibility #697

candideu opened this issue Feb 13, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@candideu
Copy link
Contributor

candideu commented Feb 13, 2022

Is your feature request related to a problem? Please describe.

Hello! I've been really enjoying the latest release, especially the ability to edit the css and js of the public pages and admin panel.

That said, I noticed that the public subscription forms are missing key attributes like #ids, for=, and aria-labels. These are helpful for accessibility, or to further customize things like placeholders (see: Labeling Controls).

image

Describe the solution you'd like

Code at the moment:

  <p>
    <label>E-mail</label>
    <input name="email" required="true" type="email" placeholder="E-mail" autofocus="true">
    <input name="nonce" class="nonce" value="">
  </p>
  <p>
    <label>Name (optional)</label>
    <input name="name" type="text" placeholder="Name (optional)">
  </p>

I propose something like this:

  <p>
    <label for="#-form-email">E-mail</label>
    <input name="email" required="true" type="email" placeholder="E-mail" autofocus="true" id="#-form-email" aria-label="email">
    <input name="nonce" class="nonce" value="">
  </p>
  <p>
    <label for="#-form-name">Name (optional)</label>
    <input name="name" type="text" placeholder="Name (optional)" id="#-form-name" aria-label="name">
  </p>
@candideu
Copy link
Contributor Author

Thanks for the fix @shrilakshmishastry

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant