-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Set app.root_url from TOML or env var #705
Comments
Setting |
That would be too easy. No luck with I've added a note for now to update this in Settings. Available for testing here: https://www.pikapods.com/apps |
Ah yes, sorry, my bad. DB settings override environment variables for precisely the same reason. If env vars took precedence, then whatever is configured on the settings UI would be moot, rendering settings unreliable wholly. |
Thanks for checking. I'll manage Set the optional setting Happy to do a PR if this is a desired change. |
+1. Makes sense. |
Is your feature request related to a problem? Please describe.
Just set up Listmonk for use with PikaPods.com. Works all well thus far. I just noticed that it's not possible to set
app.root_url
andapp.logo_url
(defined here during initial setup. It just defaults tolocalhost:9000
. As a result the logo won't load and the user needs to visit the Settings page to update the URL.Describe the solution you'd like
It would be helpful to set at least
app.root_url
in the TOML file during initial setup or use a value from there during initial setup. Editing the URL in Settings is helpful too, so I see why it's not in the TOML.Alternative I've considered is to run a DB query to update this setting after running
--install
.The text was updated successfully, but these errors were encountered: