From 84a331f15eb8710cedf5474f84565d25dc86ef47 Mon Sep 17 00:00:00 2001 From: Knative Prow Robot Date: Wed, 12 Jun 2024 14:25:52 +0100 Subject: [PATCH] [release-1.14] Fix possible nil pointer dereference in event-dispatcher (#7997) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Fix possible nil pointer dereference in event-dispatcher * readErr -> err --------- Co-authored-by: Christoph Stäbler --- pkg/kncloudevents/event_dispatcher.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/kncloudevents/event_dispatcher.go b/pkg/kncloudevents/event_dispatcher.go index a80a17f6e41..a62cddd764a 100644 --- a/pkg/kncloudevents/event_dispatcher.go +++ b/pkg/kncloudevents/event_dispatcher.go @@ -325,11 +325,11 @@ func (d *Dispatcher) executeRequest(ctx context.Context, target duckv1.Addressab dispatchInfo.ResponseHeader = response.Header body := new(bytes.Buffer) - _, readErr := body.ReadFrom(response.Body) + _, err = body.ReadFrom(response.Body) if isFailure(response.StatusCode) { // Read response body into dispatchInfo for failures - if readErr != nil && readErr != io.EOF { + if err != nil && err != io.EOF { dispatchInfo.ResponseBody = []byte(fmt.Sprintf("dispatch resulted in status \"%s\". Could not read response body: error: %s", response.Status, err.Error())) } else { dispatchInfo.ResponseBody = body.Bytes() @@ -341,7 +341,7 @@ func (d *Dispatcher) executeRequest(ctx context.Context, target duckv1.Addressab } var responseMessageBody []byte - if readErr != nil && readErr != io.EOF { + if err != nil && err != io.EOF { responseMessageBody = []byte(fmt.Sprintf("Failed to read response body: %s", err.Error())) } else { responseMessageBody = body.Bytes()