Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[kraken] integer overflow for channelIDs #4961

Open
rvullriede opened this issue Nov 7, 2024 · 1 comment
Open

[kraken] integer overflow for channelIDs #4961

rvullriede opened this issue Nov 7, 2024 · 1 comment

Comments

@rvullriede
Copy link
Contributor

rvullriede commented Nov 7, 2024

Kraken is nowadays using values for channelIDs that are exceeding the INT range:

`
2024-11-07T20:45:40.271Z ERROR 3823345 --- [nioEventLoopGroup-2-1] i.b.x.kraken.KrakenStreamingService : Error reading message: Numeric value (6184774270989) out of range of int (-2147483648 - 2147483647)
at [Source: UNKNOWN; byte offset: #UNKNOWN] (through reference chain: info.bitrich.xchangestream.kraken.dto.KrakenSubscriptionStatusMessage["channelID"])

com.fasterxml.jackson.databind.JsonMappingException: Numeric value (6184774270989) out of range of int (-2147483648 - 2147483647)
at [Source: UNKNOWN; byte offset: #UNKNOWN] (through reference chain: info.bitrich.xchangestream.kraken.dto.KrakenSubscriptionStatusMessage["channelID"])
at com.fasterxml.jackson.databind.JsonMappingException.wrapWithPath(JsonMappingException.java:402)
at com.fasterxml.jackson.databind.JsonMappingException.wrapWithPath(JsonMappingException.java:361)
at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.wrapAndThrow(BeanDeserializerBase.java:1826)
at com.fasterxml.jackson.databind.deser.BeanDeserializer._deserializeWithErrorWrapping(BeanDeserializer.java:566)
at com.fasterxml.jackson.databind.deser.BeanDeserializer._deserializeUsingPropertyBased(BeanDeserializer.java:439)
at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.deserializeFromObjectUsingNonDefault(BeanDeserializerBase.java:1405)
at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserializeFromObject(BeanDeserializer.java:352)
at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:185)
at com.fasterxml.jackson.databind.deser.DefaultDeserializationContext.readRootValue(DefaultDeserializationContext.java:323)
at com.fasterxml.jackson.databind.ObjectMapper._readValue(ObjectMapper.java:4706)
at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:2879)
at com.fasterxml.jackson.databind.ObjectMapper.treeToValue(ObjectMapper.java:3343)
at info.bitrich.xchangestream.kraken.KrakenStreamingService.handleMessage(KrakenStreamingService.java:164)
`

The field needs to be changed to Long.

@rvullriede
Copy link
Contributor Author

Any objections to get this merged?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant