Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

defmt-print: remove supported version from help output #353

Closed
Lotterleben opened this issue Jan 21, 2021 · 3 comments
Closed

defmt-print: remove supported version from help output #353

Lotterleben opened this issue Jan 21, 2021 · 3 comments
Labels
good first issue Good for newcomers

Comments

@Lotterleben
Copy link
Contributor

As mentioned by @japaric in knurling-rs/probe-run#133 , knurling-rs/probe-run#131 applies to defmt-print too.

Modification should probably take place in

defmt/print/src/main.rs

Line 95 in 574f77f

fn version() -> &'static str {

Opening this as another issue so we don't forget.
@Lotterleben Lotterleben added the good first issue Good for newcomers label Jan 21, 2021
@japaric
Copy link
Member

japaric commented Jan 21, 2021

PR #352 will fix this

@Lotterleben
Copy link
Contributor Author

oh whoops

@jonas-schievink
Copy link
Contributor

#352 was merged

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Lotterleben @jonas-schievink @japaric