Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Fix snapshot tests #279

Closed
BriocheBerlin opened this issue Nov 19, 2021 · 2 comments
Closed

Fix snapshot tests #279

BriocheBerlin opened this issue Nov 19, 2021 · 2 comments
Labels
type: bug Something isn't working

Comments

@BriocheBerlin
Copy link
Contributor

BriocheBerlin commented Nov 19, 2021

When running the snapshot tests, 3 of them fail, namely panic_verbose, successful_run_can_enforce_backtrace and panic_is_reported_as_such.

For one, setting up the canary takes a different amount of time.
Also name demangling seems to fail (see also #201 )

Screenshot 2021-11-18 at 13 19 52

Apparently the last good commit is 73ba0cc, "Merge #253" . In between then and now there seem to be a changing number of failures.

@BriocheBerlin BriocheBerlin added the type: bug Something isn't working label Nov 19, 2021
@jonathanpallant
Copy link
Contributor

#280 should fix the demangling?

@Lotterleben
Copy link

I've re-ran the tests on main– this issue seems to be fixed by now (by #280?), but one test still fails due to updated logging statements– will open a separate PR for that

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants