Skip to content

[opsgenie] Adjust permission schema and add support for incident actions #248

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
ricoberger opened this issue Dec 25, 2021 · 0 comments · Fixed by #260
Closed

[opsgenie] Adjust permission schema and add support for incident actions #248

ricoberger opened this issue Dec 25, 2021 · 0 comments · Fixed by #260
Assignees
Labels
enhancement New feature or request

Comments

@ricoberger
Copy link
Member

ricoberger commented Dec 25, 2021

Is your feature request related to a problem? Please describe

The actions like closing or snoozing an alert can be enabled / disabled via the Opsgenie configuration, but they can not be controlled on a per user / team level.

In #219 we implemented a permission schema for plugins, which is already used for the Azure plugin. We should adopt this schema for the Opsgenie plugin, so that the actions can be enabled for each user / team seperatly.

Besides the adjustment of the permissions schema, we should also add actions for incidents similar to the ones for alerts. With these new actions users should be able to resolve and close alerts.

Describe the solution you'd like

The permission scheme for the Opsgenie plugin can look as follows:

---
apiVersion: kobs.io/v1beta1
kind: Team
metadata:
  name: team1
spec:
  id: team1@kobs.io
  permissions:
    plugins:
      - name: opsgenie
        permissions:
          - closeAlert
          - snoozeAlert
          - acknowledgeAlert
          - resolveIncident
          - closeIncident

In the above example all users which are part of team1 can close, snooze and acknowledge alerts and they can resolve and close incidents.

The permissions property of a plugin contains a list of actions, which are allowed for a user / team. This way we can simply merge the actions list, when the plugin permissions are defined for multiple teams or on the user and team level.

Additional context

With the new permission handling in the Opsgenie plugin, we can unify the permission handling in plugins, which makes the permission handling easier for users.

One thing we have to consider is, that when we are using this permission model, we would remove the options to control the allowed actions, for users which are using kobs with out the auth middleware.

@ricoberger ricoberger added the enhancement New feature or request label Dec 25, 2021
@ricoberger ricoberger moved this to Todo in v1.0.0 Dec 25, 2021
@ricoberger ricoberger changed the title [opsgenie] Adjust permission modal and add support for incident actions [opsgenie] Adjust permission schema and add support for incident actions Dec 26, 2021
@ricoberger ricoberger self-assigned this Dec 27, 2021
@ricoberger ricoberger moved this from Todo to In Progress in v1.0.0 Dec 27, 2021
Repository owner moved this from In Progress to Done in v1.0.0 Dec 27, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant