Skip to content

Commit 3236f07

Browse files
authoredSep 4, 2024
🐛 Close dropdown after selection or click outside the list (#2077) (#2078)
Fix applies to bulk selection dropdown and to filter categories dropdown on all table-based screens. Resolves: https://issues.redhat.com/browse/MTA-3321 Backport-of: #2077 Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
1 parent e1c60f1 commit 3236f07

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed
 

‎client/src/app/components/FilterToolbar/FilterToolbar.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ export const FilterToolbar = <TItem, TFilterCategoryKey extends string>({
203203
{!showFiltersSideBySide && (
204204
<ToolbarItem>
205205
<Dropdown
206+
onOpenChange={(flag) => setIsCategoryDropdownOpen(flag)}
206207
toggle={(toggleRef) => (
207208
<MenuToggle
208209
id="filtered-by"

‎client/src/app/components/ToolbarBulkSelector.tsx

+4
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ export const ToolbarBulkSelector = <T,>({
7878
<DropdownItem
7979
onClick={() => {
8080
handleSelectAll(false);
81+
setIsOpen(false);
8182
}}
8283
data-action="none"
8384
key="select-none"
@@ -91,6 +92,7 @@ export const ToolbarBulkSelector = <T,>({
9192
currentPageItems.map((item: T) => item),
9293
true
9394
);
95+
setIsOpen(false);
9496
}}
9597
data-action="page"
9698
key="select-page"
@@ -101,6 +103,7 @@ export const ToolbarBulkSelector = <T,>({
101103
<DropdownItem
102104
onClick={() => {
103105
handleSelectAll(true);
106+
setIsOpen(false);
104107
}}
105108
data-action="all"
106109
key="select-all"
@@ -116,6 +119,7 @@ export const ToolbarBulkSelector = <T,>({
116119
<ToolbarItem>
117120
<Dropdown
118121
isOpen={isOpen}
122+
onOpenChange={(flag) => setIsOpen(flag)}
119123
toggle={(toggleRef) => (
120124
<MenuToggle
121125
ref={toggleRef}

0 commit comments

Comments
 (0)