Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Colors icon in dark theme incorrect #29

Closed
jsaenzh01 opened this issue Mar 3, 2024 · 5 comments
Closed

Colors icon in dark theme incorrect #29

jsaenzh01 opened this issue Mar 3, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@jsaenzh01
Copy link

Describe the bug
In plasma 6, icon is showed dark, in a dark theme.

To Reproduce

  1. Install nordvpn
  2. Show a dark color

Expected behavior
A expected a white icon in a dark color

Screenshots
Captura de pantalla_20240303_050333

Desktop (please complete the following information):

  • Distribution: Opensuse 15.5
  • KDE Plasma 6.0
  • KDE Frameworks 6.0
  • NordVPN 1.0

Additional context
Thanks for porting plasmoid so fast!

@jsaenzh01 jsaenzh01 added the bug Something isn't working label Mar 3, 2024
@korapp
Copy link
Owner

korapp commented Mar 4, 2024

I've tested this on KDE Neon and the icon behaves correctly, so maybe it's a problem with the packages or the update process.

  1. Have you installed Plasma 6 yourself from a third party repository (OpenSUSE Argon seems to be based on Leap 15.4)?
  2. Is this a new installation or was it updated from Plasma 5?
    1. If the latter, did you use the plasmoid before?

@korapp korapp added the question Further information is requested label Mar 4, 2024
@jsaenzh01
Copy link
Author

Hi,
1.- I installed Kde 6.0 from Opensuse repos:
https://en.opensuse.org/SDB:KDE_repositories

`zypper ar -fp 75 'https://download.opensuse.org/repositories/KDE:/Qt5/openSUSE_Leap_$releasever' KDE-Qt5
zypper ar -fp 75 'https://download.opensuse.org/repositories/KDE:/Qt6/openSUSE_Leap_$releasever' KDE-Qt6
zypper ar -fp 75 'https://download.opensuse.org/repositories/KDE:/Frameworks/openSUSE_Leap_$releasever' KDE-Frameworks
zypper ar -fp 75 'https://download.opensuse.org/repositories/KDE:/Frameworks5/openSUSE_Leap_$releasever' KDE-Frameworks5
zypper ar -fp 75 'https://download.opensuse.org/repositories/KDE:/Applications/KDE_Frameworks5_openSUSE_Leap_$releasever' KDE-Applications
zypper ar -fp 75 'https://download.opensuse.org/repositories/KDE:/Extra/KDE_Applications_openSUSE_Leap_$releasever' KDE-Extra
zypper -v dup --allow-vendor-change

TBD, not available just yet

zypper -v install pattern:kde_plasma6

`

It's not a new installation. I have used for a long time. I have used your plasmoid since one year ago. I had to uninstall old version in order to install version 1.0.

I also delete all config files related to plasma -> rm .config/plasma* .

I use breeze twilight theme (no dark). Maybe Its the difference. I have also reapplied the theme.
Captura de pantalla_20240304_193715

Thanks for answering! and I'm sorry for my english! (it's not my first language)

@korapp
Copy link
Owner

korapp commented Mar 5, 2024

I use breeze twilight theme (no dark). Maybe Its the difference. I have also reapplied the theme.

This is it!
It looks like Plasma 6 sets the ColorScheme-Text from Application Style, which in the case of the Twilight theme results in a dark icon on a dark panel.
I will dig deeper, but for now I see that Plasma itself has similar problems:
Screenshot_20240305_221701
(plasmoidviewer)

@korapp korapp removed the question Further information is requested label Mar 5, 2024
@jsaenzh01
Copy link
Author

jsaenzh01 commented Mar 15, 2024

Hi,
With your answer, I open a bug in Kde:
https://bugs.kde.org/show_bug.cgi?id=482645

Some color icons (discover, for example) are correct now.

Maybe it helps...

@korapp
Copy link
Owner

korapp commented Mar 19, 2024

Great! I recently received 6.0.2, but it does not fix the theming of the "external" icons.
However, it seems that setting a complementary color set fixes the issue.

@korapp korapp closed this as completed in 917a7da Mar 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants