Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update hflip and vflip with mutable signatures #103

Closed
edgarriba opened this issue Aug 17, 2024 · 4 comments
Closed

Update hflip and vflip with mutable signatures #103

edgarriba opened this issue Aug 17, 2024 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@edgarriba
Copy link
Member

After this refactor #102 hflip a and vflip` were pending to be completed
@edgarriba edgarriba added enhancement New feature or request help wanted Extra attention is needed labels Aug 17, 2024
@emilmgeorge
Copy link
Contributor

Hi,

I'm interested in taking this up.

As I understand from the linked PR, we have to use a mutable dst parameter for the output instead of returning, and also adjust the loop slightly for that. Please let me know if there is anything else I should consider. I have started with hflip function and hope to have something for your review soon.

@edgarriba
Copy link
Member Author

@emilmgeorge yes, that's it. Beware that this morning i merged the last of series of PR to ndarray as dep. See: #116

you might have to rebase

@emilmgeorge
Copy link
Contributor

Thanks, yes I saw it just after I posted my prev comment. I have since rebased and updated my changes. Will PR now.

@emilmgeorge emilmgeorge mentioned this issue Sep 1, 2024
Merged
@edgarriba
Copy link
Member Author

merged in #117

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emilmgeorge @edgarriba