Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(venmo): window name #443

Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix(venmo): window name #443

merged 2 commits into from
Oct 30, 2023

Conversation

mnicpt
Copy link
Contributor

@mnicpt mnicpt commented Oct 30, 2023

Issue

Window name wasn't being updated if redirecting in popup. This caused blank windows to open when sending focus event to popup as window name did not match.

Solution

Send updated name to parent initialization to update the proxy window name.

@mnicpt mnicpt requested a review from a team as a code owner October 30, 2023 15:57
Copy link
Contributor

@nbierdeman nbierdeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!! 🚀

@mnicpt mnicpt merged commit 02bcaab into main Oct 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants