Skip to content

Option to filter out imperative benchmarks #1121

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
L3P3 opened this issue Oct 18, 2022 · 3 comments
Open

Option to filter out imperative benchmarks #1121

L3P3 opened this issue Oct 18, 2022 · 3 comments

Comments

@L3P3
Copy link
Contributor

L3P3 commented Oct 18, 2022

I know it is a bit hard to decide where to draw the line but I would like to filter out frameworks that involve imperative operations like "set the class of element x", as seen in here. Even if it is not a direct dom manipulation, I (author of lui) consider it cheating if you have all that functional/declarative style and then suddenly "help" the framework to make something faster.

I do not deem imperative style an issue per se but I want to be able to rule it out in my projects as much as possible and rely on plain stupid data => view translation. 😉

@krausest
Copy link
Owner

Not sure I fully understand your request. Those frameworks should have issue #772 added. Is that the case (xaniajs's is marked #772)?
If those are marked with #772 you can deselect those frameworks:
Bildschirmfoto 2022-10-18 um 20 30 22

P.S: Seems like I caused a regression in d6f4edd. If you deselect #772, vanillajs isn't counted anymore and scores 0.97. I'll take a look at that.

@krausest
Copy link
Owner

That regression is fixed now.

@L3P3
Copy link
Contributor Author

L3P3 commented Oct 19, 2022

Ich meine, dass ich einfach nur die Implementationen sehen will, die die Ansicht zu 100% aus dem kanonischen Zustand ableiten, ohne imperative Umwege.
Beispielsweise möchte ich, dass wenn ein Listeneintrag ausgewählt wird, nur eine einzige Variable/Eigenschaft gesetzt wird und mehr nicht. All die Implementationen, welche irgendetwas mehr tun, wie etwa den Listeneintrag selbst rauszusuchen und zu verändern, oder sogar explizit die Klassen-Liste des DOMs verändern, möchte ich gerechterweise rausfiltern können.
Der bestehende Filter nach direkter DOM-Manipulation reicht mir nicht. Wenn diese einfach nur etwas versteckt wird, wie in dem verlinkten Beispiel, ist es keine direkte DOM-Manipulation, zerstört aber das treue State=>View-Prinzip, welches ich nahezu religiös vertrete. 😉

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants