encode_path on url

[allaire]

Hi, I had to monkey path to add encode_path to the url method, like this:

module AzureEncodingPatch
  include CarrierWave::Utilities::Uri

  def url(options = {})
    path = ::File.join @uploader.azure_container, encode_path(@path)
    if @uploader.asset_host
      "#{@uploader.asset_host}/#{path}"
    else
      uri = @connection.generate_uri(path)
      if sign_url?(options)
        @signer.signed_uri(uri, false, { permissions: 'r',
                                         resource: 'b',
                                         start: 1.minute.ago.utc.iso8601,
                                         expiry: expires_at}).to_s
      else
        uri.to_s
      end
    end
  end
end

Otherwise, images with spaces in it were failing. Should I create a PR?

[allaire]

@krismichalski URI.encode could also be used I suppose!

From what I see, it seems to be pretty standard to use the encoded_path, at least in the fog storage:

https://github.com/carrierwaveuploader/carrierwave/blob/540a84c606353a878d6574740e44f7970b754463/lib/carrierwave/storage/fog.rb#L335

[krismichalski]

Hi @allaire, great catch!
Yes, if you could create PR with encode_path patch it would be great.
It would be even more awesome if you could add a test case for files with spaces in them.
Unfortunately, I no longer have access to Azure, so I cannot develop it by myself.

[allaire]

@krismichalski Good, will try to get this done soonish!